Group 91 is the correct battery for the trunk of E30's (Group 48 is a little tall but will also fit). I would recommend a conventional battery, they work totally fine with the electrical system on older BMWs. I hear Costco offers a good warranty at a low price, the money you save is better spent to rebuild the alternator. No Optima will fit nicely and in my opinion their quality has taken a dive in recent years.
You can also shoehorn a Group 49 battery in there, only if your running a huge stereo or frequent drive-in movies. Otherwise it's just dead weight because the lights and fans are powered by the alternator when the engine is running. Battery is typically used only when starting the car and powering the door locks.
PS. Make sure you have a working vent hose.