318is engine swap (same engine size)

[erupert66]

I picked up a '91 318is with a blown engine (#2 rod through the block) for my 16yo son.  It's been a long project so the car has been in my garage since Oct 2010.  Last April, i picked up an engine from a guy here on the board doing a swap.  Came with the full harness and CPU.

So, finally got the swap done and have a couple things -
1) No fuel (no signal to in-tank pump but pump runs from external battery)
2) the starter will continue to run after key shutoff sometimes so I have to quick pull the battery cable.  (Actually, haven't tried turning the key on/off to see if that would fix it but it's only happened twice.  once on the first cranking try on once last night while testing circuits.

I checked so far -
1) i pulled the fuel pump relay and it clicks when tripped manually with 12v
2) i checked the pump function by running off ext batt
3) checked fuses 10/11 and also replaced just in case.  

Questions -
1) How can I best track down why the CPU isn't triggering the relay?
2) the only area of the engine that I forgot to do a before/after is the main battery connection area. I cant seem to upload the pic even though its only 142k.  Tried uploading from a link.  no luck.  Grr.  Hope the ***** works -

https://picasaweb.google.com/s/c/transparent_album_background.gif) no-repeat left">https://picasaweb.google.com/115915252329368513884/12111?authuser=0&feat=*****website">https://lh6.googleusercontent.com/-g777xJ33a4g/TteaRX1qSIE/AAAAAAAAAF8/HCSz6hsYZTs/s160-c/12111.jpg" width="160" height="160" style="margin:1px 0 0 4px;">

https://picasaweb.google.com/115915252329368513884/12111?authuser=0&feat=*****website" style="color:#4D4D4D;font-weight:bold;text-decoration:none;">12/1/11

3) think the starter problem is a sticky relay from sitting for 15 mos or a symptom of an electrical connection problem?

[DesktopDave]

I approved your post, might want to clean up that code...some cut-n-paste operations carry unintended code along with them.